Skip to content

Conversation

@reddevilmidzy
Copy link
Contributor

Note

Intermediate commits are intended to help review, but will be squashed prior to merge.

part of #133895

Relocate 4 tests in fn-main and issues and remove fn-main directory

r? Kivooeo

@rustbot
Copy link
Collaborator

rustbot commented Nov 27, 2025

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 27, 2025
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted it because I thought it was the same as entry-point/main-with-invalid-signiture.rs. What are your thoughts on this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree with this

@rust-log-analyzer

This comment has been minimized.

@rustbot rustbot added A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 27, 2025
@Kivooeo
Copy link
Member

Kivooeo commented Nov 27, 2025

Thanks

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 27, 2025

📌 Commit ab73680 has been approved by Kivooeo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2025
@Kivooeo
Copy link
Member

Kivooeo commented Nov 27, 2025

oh wait I forget to send a review :D

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in filename "signiture"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I missed! thanks

@Kivooeo
Copy link
Member

Kivooeo commented Nov 27, 2025

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 27, 2025
@Kivooeo
Copy link
Member

Kivooeo commented Nov 27, 2025

r=me when fix and ci is green

@bors delegate+

@bors
Copy link
Collaborator

bors commented Nov 27, 2025

✌️ @reddevilmidzy, you can now approve this pull request!

If @Kivooeo told you to "r=me" after making some further change, please make that change, then do @bors r=@Kivooeo

Relocate issues/issue-51022.rs to
entry-point/main-with-lifetime-param.rs

Relocate issue-50714.rs to entry-point/main-where-fn-bound.rs

Rename issue-118772.rs to main-with-invalid-signature.rs and delete
duplicate test

remove ui/entry-point/issue-118772.rs in issues.txt

Relocate fn-main/wrong-location.rs to entry-point/main-in-submodule.rs

Remove fn-main directory

Relocate issue-50688.rs to mismatched_types/array-len-is-closure.rs
@reddevilmidzy
Copy link
Contributor Author

@bors r=@Kivooeo

@bors
Copy link
Collaborator

bors commented Nov 27, 2025

📌 Commit a5dc701 has been approved by Kivooeo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 27, 2025
bors added a commit that referenced this pull request Nov 27, 2025
Rollup of 6 pull requests

Successful merges:

 - #148256 (remove support for `typeof`)
 - #148589 (Rename `DropGuard::into_inner` to `DropGuard::dismiss`)
 - #149001 (Fix false positive of "multiple different versions of crate X in the dependency graph")
 - #149334 (fix ICE: rustdoc: const parameter types cannot be generic #149288)
 - #149345 (Deeply normalize param env in `compare_impl_item` if using the next solver)
 - #149367 (Tidying up UI tests [4/N])

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 01512aa into rust-lang:main Nov 27, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 27, 2025
rust-timer added a commit that referenced this pull request Nov 27, 2025
Rollup merge of #149367 - reddevilmidzy:t4, r=Kivooeo

Tidying up UI tests [4/N]

> [!NOTE]
> Intermediate commits are intended to help review, but will be squashed prior to merge.

part of #133895

Relocate 4 tests in fn-main and issues and remove fn-main directory

r? Kivooeo
@reddevilmidzy reddevilmidzy deleted the t4 branch November 27, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants